Repository navigation
[nodejs_lambda] Remove any calls to public.ecr.aws on critical path for nodejs lambda - #7859
Merged
CarlesDD merged 10 commits intoOct 5, 2026
Merged
Conversation
Contributor
|
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 492132d | Docs | View more details | Give us feedback! |
…ving the latest release
CarlesDD
marked this pull request as ready for review
October 1, 2026 06:14
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90fb68e570
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cbeauchesne
approved these changes
Oct 5, 2026
CarlesDD
enabled auto-merge (squash)
October 5, 2026 19:48
CarlesDD
deleted the
ccapell/APPSEC-68818/nodejs-lambda-remove-ecr-calls
branch
October 5, 2026 21:51
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Same rationale as #7838 (which did this for
python_lambda): thenodejs_lambdaweblog Dockerfiles callpublic.ecr.aws/lambda/nodejsandpublic.ecr.aws/datadog/lambda-extensiondirectly, on the critical path of every build. This applies the same fix to the Node.js weblogs.Changes
utils/build/docker/nodejs_lambda/runtime.base.Dockerfile: extracts the shared preamble (base runtime image + Datadog Extension) out of the five per-trigger Dockerfiles into one image, built once and mirrored like every other base image in this repo instead of pulled from public.ecr.aws on every build.utils/build/docker/nodejs_lambda/docker-bake.hcl: bake file for that base image, following the same pattern aspython_lambda's.nodejs-alb.Dockerfile,nodejs-alb-multi.Dockerfile,nodejs-apigw-http.Dockerfile,nodejs-apigw-rest.Dockerfile,nodejs-function-url.Dockerfile: replaced theirpublic.ecr.awspreamble withFROM system_tests_base_nodejs_lambda_nodejs_lambda_runtime.Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟